Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRIVIAL: use ESLint instead of TSLint #233

Merged
merged 31 commits into from
Oct 2, 2019
Merged

TRIVIAL: use ESLint instead of TSLint #233

merged 31 commits into from
Oct 2, 2019

Conversation

mrmlnc
Copy link
Owner

@mrmlnc mrmlnc commented Oct 1, 2019 •
edited
Loading

What is the purpose of this pull request?

Upgrading the infrastructure of the repository. TSLint will be deprecated some time in 2019.

palantir/tslint#4534

mrmlnc added 28 commits September 30, 2019 22:02
@mrmlnc
build(package): replace TSLint by ESLint
2ea218f
@mrmlnc
style: fix ban-types rule
72fa5d0
@mrmlnc
style: fix explicit-function-return-type rule
9a755f4
@mrmlnc
style: fix generic-type-naming rule
ad7afae
@mrmlnc
style: fix member-ordering rule
5363bd4
@mrmlnc
style: fix no-extra-parens rule
88367f9
@mrmlnc
style: fix no-unnecessary-condition rule
57425a0
@mrmlnc
style: fix no-explicit-any rule
16a9803
@mrmlnc
style: fix prefer-includes rule
c5ac139
@mrmlnc
style: fix import/order rule
1ce7952
@mrmlnc
style: fix no-unused-expressions rule
b9e594c
@mrmlnc
style: fix no-useless-escape rule
97bd53c
@mrmlnc
style: fix custom-error-definition rule
5bb3e0d
@mrmlnc
style: fix padding-line-between-statements rule
5855ce1
@mrmlnc
style: fix unicorn/prefer-spread rule
2aa6fe0
@mrmlnc
style: fix import/first rule
5540cfe
@mrmlnc
style: fix require-array-sort-compare rule
38aecef
@mrmlnc
style: fix capitalized-comments rule
e63b0cb
@mrmlnc
style: fix no-magic-numbers rule
1858f51
@mrmlnc
style: fix consistent-type-definitions rule
c06f89f
@mrmlnc
style: fix no-redeclare rule
bfc3b67
@mrmlnc
style: fix unicorn/import-index rule
cbcabd0
@mrmlnc
style(benchmark): rename getMeasures → formatMeasures
376b8fa
@mrmlnc
style: fix consistent-type-assertions rule
4a6c244
@mrmlnc
style: fix unicorn/prevent-abbreviations rule
027dab5
@mrmlnc
style: fix strict-boolean-expressions rule
89266ef
@mrmlnc
style: fix no-require-imports rule
abdf027
@mrmlnc
style: fix no-misused-promises rule
c59673d
@mrmlnc
Copy link
Owner Author

mrmlnc commented Oct 1, 2019

/azp run benchmark.regression.object

@mrmlnc
Copy link
Owner Author

mrmlnc commented Oct 1, 2019

/azp run benchmark.regression

@mrmlnc
Copy link
Owner Author

mrmlnc commented Oct 1, 2019

/azp run benchmark

@mrmlnc
Copy link
Owner Author

mrmlnc commented Oct 1, 2019

/azp run benchmark.regression

@mrmlnc
Copy link
Owner Author

mrmlnc commented Oct 1, 2019

/azp run benchmark.regression

@mrmlnc mrmlnc added this to the 3.1.0 milestone Oct 1, 2019
@mrmlnc
Copy link
Owner Author

mrmlnc commented Oct 1, 2019 •
edited
Loading

Very strange diff between the previous and current version ~ +5-7ms.

Run with 500 launches for the current branch:

The same configuration for the master branch:

@mrmlnc
Copy link
Owner Author

mrmlnc commented Oct 1, 2019

/azp run benchmark.regression

@mrmlnc
Copy link
Owner Author

mrmlnc commented Oct 1, 2019

/azp run benchmark.regression

@mrmlnc
Copy link
Owner Author

mrmlnc commented Oct 1, 2019 •
edited
Loading

Benchmark's:

  1. Before prefer-includes rule
  2. Only replace TSLint
  3. As is

Looks like a noise.

@mrmlnc mrmlnc marked this pull request as ready for review October 1, 2019 20:55
@mrmlnc
Copy link
Owner Author

mrmlnc commented Oct 1, 2019

/azp run build

@mrmlnc
Copy link
Owner Author

mrmlnc commented Oct 1, 2019

/azp run benchmark.regression

@mrmlnc
Copy link
Owner Author

mrmlnc commented Oct 1, 2019

/azp run benchmark.regression.object

@mrmlnc
Copy link
Owner Author

mrmlnc commented Oct 1, 2019

/azp run benchmark.regression.absolute

mrmlnc
mrmlnc commented Oct 1, 2019
View reviewed changes
src/index.spec.ts Outdated Show resolved Hide resolved
mrmlnc
mrmlnc commented Oct 1, 2019
View reviewed changes
src/benchmark/runner.ts Outdated Show resolved Hide resolved
mrmlnc
mrmlnc commented Oct 1, 2019
View reviewed changes
src/benchmark/index.ts Outdated Show resolved Hide resolved
mrmlnc
mrmlnc commented Oct 1, 2019
View reviewed changes
src/types/index.ts Outdated Show resolved Hide resolved
@mrmlnc
Copy link
Owner Author

mrmlnc commented Oct 2, 2019

/azp run benchmark.regression

@mrmlnc mrmlnc merged commit 6ec8664 into master Oct 2, 2019
@mrmlnc mrmlnc deleted the eslint branch October 2, 2019 07:13
This was referenced Mar 10, 2020
Closed
Open
@snyk-bot snyk-bot mentioned this pull request May 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@mrmlnc